chore(atlas-service): use server oidc browser setting for atlas login COMPASS-7063 #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
addaleax
approved these changes
Sep 22, 2023
…r error handling Co-authored-by: Anna Henningsen <[email protected]>
Co-authored-by: Anna Henningsen <[email protected]>
|
Updated labels based on input from Julia, looks like this now:
@addaleax do you mind giving it a quick look? Does it still look good to you after the changes? |
gribnoysup
commented
Sep 25, 2023
gribnoysup
commented
Sep 25, 2023
…cit label for server oidc settings More product feedback
addaleax
approved these changes
Sep 25, 2023
gribnoysup
deleted the
compass-7063-use-server-oidc-browser-setting-for-atlas-login
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in COMPASS-7063, we want to use MongoDB server OIDC auth browser option for Atlas Login flow, this patch updates atlas-service to use property from preferences and updates documentation of the OIDC options to try to make it clear how they will apply.
I'll check description changes with product before merging this